Remove Iceberg connector tests for REST and JDBC catalogs#16588
Merged
findepi merged 1 commit intotrinodb:masterfrom Mar 16, 2023
Conversation
findepi
added
test
no-release-notes
Member
Author
Member
Author
|
@ebyhr will this allow us to remove |
Member
Author
|
i will remove |
Like for Glue, we have connector *smoke* tests for these. This also removes `additional-catalog-tests` profile, as the remaining tests are short enough not to warrant a separate profile on the CI (below 2:30 minutes).
findepi
force-pushed
the
findepi/remove-iceberg-connector-tests-for-rest-and-jdbc-catalogs-75420b
branch
from
74ff594 to
8d70a16
Compare
alexjo2144
approved these changes
Mar 16, 2023
Member
alexjo2144
left a comment
alexjo2144
left a comment
There was a problem hiding this comment.
A smoke test per catalog implementation seems reasonable to me 👍
ebyhr
approved these changes
Mar 16, 2023
findepi
deleted the
findepi/remove-iceberg-connector-tests-for-rest-and-jdbc-catalogs-75420b
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like for Glue, we have connector smoke tests for these.